Add type restrictions to regex directory #16066
Open
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the output of compiling [cr-source-typer](https://github.com/Vici37/cr-source-typer) and running it with the below incantation: ``` CRYSTAL_PATH="./src" ./typer spec/std_spec.cr \ --error-trace --exclude src/crystal/ \ --stats --progress \ --union-size-threshold 2 \ --ignore-private-defs \ src/regex ``` This is related to crystal-lang#15682 .
straight-shoota
approved these changes
Aug 6, 2025
mverzilli
approved these changes
Aug 12, 2025
Sija
reviewed
Aug 12, 2025
| # re.match("sledding") # => Regex::MatchData("sledding") | ||
| # ``` | ||
| def +(other) : Regex | ||
| def +(other : Regex) : Regex |
There was a problem hiding this comment.
That's what Regex.union accepts:
Suggested change
| def +(other : Regex) : Regex | |
| def +(other : Regex | String) : Regex |
There was a problem hiding this comment.
It seems a bit odd though. I don't think the String overload is much useful. Maybe we should deprecate that?
For this PR it might just be best to remove the type restriction. We can follow up with a dedicated change.
Comment on lines
671
to
+672
| @[Deprecated("Use the overload with `Regex::MatchOptions` instead.")] | ||
| def match(str, pos = 0, *, options) : MatchData? | ||
| def match(str : String, pos : Int32 = 0, *, options : Regex::Options) : MatchData? |
There was a problem hiding this comment.
Is it worth adding type restrictions to a deprecated methods?
ditto elsewhere
There was a problem hiding this comment.
That's a good catch. Probably not.
However, since it's already there...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the output of compiling cr-source-typer and running it with the below incantation:
This is related to #15682 .