Mark __crystal_personality as nodoc [fixup #15070]
#15219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Nov 23, 2024
straight-shoota
changed the title
__crystal_personality as nodoc__crystal_personality as nodoc [fixup #15070]
straight-shoota
changed the title
__crystal_personality as nodoc [fixup #15070]__crystal_personality as nodoc [fixup #15070]
RX14
approved these changes
Nov 24, 2024
|
The actual |
Good catch! |
ysbaddaden
approved these changes
Nov 25, 2024
straight-shoota
approved these changes
Nov 25, 2024
| @@ -207,12 +207,14 @@ end | |||
| alias DISPATCHER_CONTEXT = Void | |||
| end | |||
|
|
|||
| # :nodoc: | |||
| lib LibUnwind | |||
There was a problem hiding this comment.
nitpick: Lib types are nodoc by default, so this is technically unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this internal function is not
:nodoc:since #15070:API Link