Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro interpolation in NamedTuple#from #14790

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Fix macro interpolation in NamedTuple#from #14790

merged 1 commit into from
Jul 7, 2024

Conversation

HertzDevil
Copy link
Contributor

This is similar to #14785 where "{{key}}" could interfere the surrounding syntax tree depending on key's contents.

@straight-shoota straight-shoota added this to the 1.13.0 milestone Jul 6, 2024
@straight-shoota straight-shoota merged commit 1f240d3 into crystal-lang:master Jul 7, 2024
61 checks passed
@HertzDevil HertzDevil deleted the bug/namedtuple-from branch July 7, 2024 19:53
kojix2 pushed a commit to kojix2/crystal that referenced this pull request Jul 9, 2024
@HertzDevil @kojix2
Fix macro interpolation in NamedTuple#from (crystal-lang#14790)
ba518e1
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:collection
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HertzDevil @straight-shoota