Add exception classes #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Dec 21, 2023
src/mysql/connection.cr
Outdated
| end | ||
|
|
||
| class UnexpectedPacketError < PacketError | ||
| getter :status |
There was a problem hiding this comment.
I would stick with getter status : UInt8 style
There was a problem hiding this comment.
I'm admittedly inexperience with Crystal so I'll take the style advice, see 7fadad9.
src/mysql/connection.cr
Outdated
| class PacketError < ConnectionError | ||
| getter :packet | ||
|
|
||
| def initialize(packet : ReadPacket, message) |
There was a problem hiding this comment.
I don't think ReadPacket should be exposed, it's an internal implementation detail.
There was a problem hiding this comment.
Check out the changes on c14f4e6; I'm hoping it addresses your concern.
1. Remove `PacketError` 2. Make `UnexpectedPacketError` inherit from `Exception` rather than `PacketError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
While I used different classes for the exceptions, I wanted to keep some level of backward-compatibility by retaining the existing error messages.