Skip to content

Fix dependencies bounded integers #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2025
Merged

Conversation

W95Psp
Copy link
Member

@W95Psp W95Psp commented Jul 29, 2024

This PR:

  • fixes a bug regarding the use of hax_bounded_integers::refinement_int (macro_rules rely on dependencies which were then not available at callsite)
  • add support for negation

@W95Psp W95Psp force-pushed the fix-dependencies-bounded-integers branch from 90c8b0e to 6e3485d Compare July 29, 2024 11:45
@W95Psp W95Psp requested a review from karthikbhargavan July 29, 2024 11:46
Copy link

This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 28, 2024
Copy link

github-actions bot commented Oct 6, 2024

This PR has been closed due to a lack of activity since being marked as stale. If you believe this pull request is still relevant, please reopen it with an update or comment.

@github-actions github-actions bot closed this Oct 6, 2024
@W95Psp
Copy link
Member Author

W95Psp commented Nov 18, 2024

I think we should have merged this one.

@W95Psp W95Psp reopened this Nov 18, 2024
@W95Psp W95Psp removed the stale label Nov 18, 2024
@W95Psp W95Psp force-pushed the fix-dependencies-bounded-integers branch from 6e3485d to c9e7055 Compare November 18, 2024 08:45
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually use bounded integers now? I thought it didn't hit the mark. If we do, let's get it in. If not, let's talk about what to do with this.

@karthikbhargavan
Copy link
Contributor

Let's meet to discuss bounded integers in general. We may want to revert some of this.

@franziskuskiefer
Copy link
Member

@W95Psp lets get it fixed and merged

@W95Psp W95Psp force-pushed the fix-dependencies-bounded-integers branch from c9e7055 to 985057a Compare November 28, 2024 12:52
@W95Psp W95Psp force-pushed the fix-dependencies-bounded-integers branch from 985057a to e086d99 Compare November 28, 2024 12:55
@W95Psp W95Psp enabled auto-merge November 28, 2024 12:55
@W95Psp
Copy link
Member Author

W95Psp commented Nov 28, 2024

I fixed the PR, we should be able to merge it now

@franziskuskiefer
Copy link
Member

@W95Psp resolve the conflict, @karthikbhargavan please review, then lets merge

@W95Psp
Copy link
Member Author

W95Psp commented Jan 23, 2025

the conflict was trivial, @karthikbhargavan you can review

@franziskuskiefer
Copy link
Member

@W95Psp @karthikbhargavan what's the state of this?

@W95Psp
Copy link
Member Author

W95Psp commented Apr 23, 2025

This PR was ready, but now conflicts. I can handle the conflicts

@W95Psp W95Psp requested a review from a team as a code owner April 23, 2025 11:31
@W95Psp W95Psp added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 2e5d758 Apr 23, 2025
15 of 16 checks passed
@W95Psp W95Psp deleted the fix-dependencies-bounded-integers branch April 23, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants