Upgrade to AsciidoctorJ v3 #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a draft for now, until I get it fully working on my blog. |
holyjak
force-pushed
the
adoc-v3
branch
4 times, most recently
from
8ecab28
to
0383379
Compare
|
Cool, just ping me when you're in a good place to merge and I can do a release. |
Upgrade to the latest AsciidoctorJ v3.0. Also, add deps.edn for easier inclusion in deps-based projects. Bump version of the plugin itself to 1 - it has been stable for a long time. Key code changes: * Use the OptionsBuilder -> Options (though as little as possible) instead of the deprecated map argument. * When cryogen's `:debug?` is on, print the final options - useful in troubleshooting
|
Status: My blog builds fine, with only small differences in something that is anyway invalid asciidoc. |
This is key internal to cryogen-asciidoc and of no interest to AsciidoctorJ.
|
Actually, it seems to be working fine now, and my Anyway, it may be best to wait with this PR until an actual release of AsciidoctorJ v3. |
|
Sure thing, code wise everything looks good and we can just wait for the release then to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest AsciidoctorJ v3.0.
Also, add deps.edn for easier inclusion in deps-based projects.
Bump version of the plugin itself to 1 - it has been stable for a long time.
Key code changes:
deprecated map argument.
:debug?is on, print the final options - useful in troubleshootingSee https://github.com/asciidoctor/asciidoctorj/blob/main/CHANGELOG.adoc for more info. There are some minor breaking changes compared to v2.5, the main one being likely that Java >=11 is not required.