-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0 #157
Open
otsch
wants to merge
12
commits into
main
Choose a base branch
from
v2-0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HttpLoader::retryCachedErrorResponses()` method now returns an instance of the new `RetryManager` class, providing the methods `only()` and `except()` that can be used to restrict retries to certain HTTP response status codes.
Start v2.0 block and improve the note for the retry cached error responses change.
Remove the methods addToResult(), addLaterToResult() and everything connected to that. Also, it is no longer possible to provide multiple loaders via the crawler. Instead you can now manually provide customized loaders directly to steps via the new withLoader() method. Further, also remove the Microseconds util class, which is now part of the crwlr/utils package.
Removes the `PaginatorInterface` and the old version of the `AbstractPaginator`. Also remove an unnecessary argument from the `processLoaded` method and the default implementation of the `getNextRequest()` method (child classes have to implement it themselves.
Remove 4 deprecated methods interacting with the headless browser helper. Users can directly call the methods on the browser helper. Also remove deprecated method `RespondedRequest::cacheKeyFromRequest()`.
Add new methods `FileCache::prolong()` and `FileCache::prolongAll()` to allow prolonging the time to live for cached responses.
Move most functionality from `Step` to `BaseStep` and make it work with `Group` steps.
Add info about changed `Crawler::addStep()` signature and removal of the `UnknownLoaderKeyException`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpLoader::retryCachedErrorResponses()
method now returns an instance of the newRetryManager
class, providing the methodsonly()
andexcept()
that can be used to restrict retries to certain HTTP response status codes.Step::addToResult()
,Step::addLaterToResult()
and everything connected to them.Step::withLoader()
method.PaginatorInterface
and the old version of theAbstractPaginator
. Also remove an unnecessary argument from theprocessLoaded
method and the default implementation of thegetNextRequest()
method (child classes have to implement it themselves.Microseconds
util class, which is now part of the crwlr/utils package.