Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure user-event folder is included into final bundle #28

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Yurickh
Copy link
Contributor

@Yurickh Yurickh commented Aug 26, 2024

What:

With the changes introduced in #24, there's a user-events folder inside the types folder that isn't being added to the final, published, library. This change ensures that this folder is also included.

Why:

image

Since there's a reference to the folder inside of types/pure.d.ts, the whole types for the userEvent library become any.

How:

By adding types/user-event/**/*.d.ts to the list of included files, we're ensuring the final bundle also includes the content of the types/user-event folder.

Checklist:

  • [N/A] Tests
  • [N/A] TypeScript definitions updated
  • [N/A] Ready to be merged

@Yurickh
Copy link
Contributor Author

Yurickh commented Oct 4, 2024

@crutchcorn are you able to please take a look at this and potentially release a patch of the library? 🙏🏼

@crutchcorn
Copy link
Owner

Huge apologies for the delay! Let me merge this, but then I'll be restructuring this project so this can't happen again

@crutchcorn crutchcorn merged commit 463facf into crutchcorn:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants