Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing because the oml_o33_2 parsing creates a OML_O33_ORDER_PRIOR #99

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jordillonch
Copy link

No description provided.

…OR which expect a OBR segment but the parser's implementation puts the OBR segment in the group OML_O33_OBSERVATION_REQUEST
@svituz
Copy link
Member

svituz commented Jan 21, 2022

This seems an ad-hoc fix for a very specific problem. I would suggest you open an issue explaining what problem you're experiencing and we'll see if there is something wrong with the message structures or something else. Attaching the hl7 message you're trying to parse would help a lot. Thanks.

@jordillonch
Copy link
Author

I tried to fix your own test. As you can see I uncommented your test: https://github.com/crs4/hl7apy/pull/99/files#diff-f1dbe79adfb6e39e76ee4519368bc4b5eaa0e4831f00165e5ac28fede4825bffR105 😄

@svituz
Copy link
Member

svituz commented Jan 21, 2022

Oh, I see, sorry 😄
I'll need to check the implementation, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants