Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SourceString API fix for strings with plural forms #206

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bhdnb
Copy link
Collaborator

@bhdnb bhdnb commented Jan 15, 2025

No description provided.

@bhdnb bhdnb linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.39%. Comparing base (3ae9950) to head (4588ada).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/CrowdinApiClient/Model/SourceString.php 95.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
+ Coverage     89.37%   89.39%   +0.03%     
- Complexity     1294     1300       +6     
============================================
  Files           119      119              
  Lines          3393     3411      +18     
============================================
+ Hits           3032     3049      +17     
- Misses          361      362       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 15ed5e7 into master Jan 16, 2025
13 checks passed
@andrii-bodnar andrii-bodnar deleted the source-string-plurals-fix branch January 16, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceString fails on pluralized string
2 participants