Only for UNIX OS, modify it to enable O_NONBLOCK and use event::read().
#920
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue is #854.
Primarily observed during mouse operations on macOS, it seems that if
O_NONBLOCKis not enabled duringevent::read(), the buffer cannot be read all at once.However, keeping
O_NONBLOCKenabled causes subsequentread()operations to malfunction, resulting in the program's termination. Therefore, I added a process that enablesO_NONBLOCKat the start ofread(), and disables it again after the reading is complete.