Add API for the terminal bell sound #806
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command that allows for ringing the terminal bell by printing the bell character.
Technically it's not an ansi code, so it felt slightly strange to put it under
Command::write_ansi
, but I don't think it makes sense to implement this separately from the Command API.I think it's somewhat justified if you reinterpret
write_ansi
as "write to the terminal potentially including ansi codes", but thenis_ansi_code_supported
doesn't make a lot of sense.But, this is one edge case so I think it's fairly reasonable. What do you think? I think this functionality - even though it's really as simple as printing a char - has a place in the Crossterm library
This should close #730