Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for automated release #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial commit for automated release #27

wants to merge 1 commit into from

Conversation

SivaanandM
Copy link
Collaborator

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

cd provider-palette
sed -i 's/^export TERRAFORM_PROVIDER_VERSION := .*/export TERRAFORM_PROVIDER_VERSION := ${{ steps.get_release.outputs.latest_version }}/' Makefile

- name: Install goimports
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you moved this step up you could club the one above it and the two below it together into a single step and only need to cd provider-palette once.

cd provider-palette
git checkout -b update-terraform-provider-${{ github.event.release.tag_name }}
git add Makefile
git add .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only git add . should be sufficient. No need to git add Makefile first.

@@ -0,0 +1,68 @@
name: Trigger PR for cross plane release
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Crossplane

git add Makefile
git add .
git commit -m "Update Terraform Provider to version ${{ github.event.release.tag_name }}"
git push origin update-terraform-provider-${{ github.event.release.tag_name }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to fail unless you configure auth using a PAT that has push access for provider-palette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants