-
Notifications
You must be signed in to change notification settings - Fork 408
xtask/build_docker_image: Add windows/amd64
platform handling
#1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, minor nit about the todo comment
regarding buildx/buildkit, there's experimental support for it, see this list for their progress: https://github.com/moby/buildkit/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%2Fwindows-wcow and this issue for the popular setup-buildx-action https://redirect.github.com/docker/setup-buildx-action/issues/292 |
As listed at for example https://docs.docker.com/build/building/multi-platform/. Allows using `--platform windows/amd64` rather than `--platform x86_64-pc-windows-msvc`.
359863b
to
7e1105f
Compare
@Emilgardis thanks, so it's What's the right way to use this As far as I understand |
We have a msvc image here already, we just don't publish its not certain it's actually any good: https://github.com/cross-rs/cross-toolchains/blob/main/docker/Dockerfile.aarch64-pc-windows-msvc-cross, it does not use the container platform cross in general does not compile through emulation, we cross-compile. Although, we do emulation on aarch64 hosts for now because we don't have the infrastructure rn to make linux/arm64 images published (see #1636) |
@Emilgardis thanks for confirming, I see now (should have opened the docker image before): it's emulating native MSVC in an Ubuntu Docker image on Trying this now on my dev machine, it is bindmounting It's also surprising that Finally, the |
As listed at for example https://docs.docker.com/build/building/multi-platform/.
Allows using
--platform windows/amd64
rather than--platform x86_64-pc-windows-msvc
.I didn't manage to use this in GitHub Actions CI on
windows-latest
just yet because it complains that--platform
is not understood, and the help text suggests thatbuildx
isn't installed in these images in the first place:Docker-Buildx
)Docker-Buildx
)