Skip to content

Commit

Permalink
- CHG: Fixing typos and method name collisions with Restlet methods.
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastian-raubach committed Aug 13, 2020
1 parent 59d1fb3 commit 43e5315
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Call<BaseResult<ArrayResult<Lists>>> getLists(
Call<BaseResult<ArrayResult<Lists>>> postLists(@Body List<Lists> newLists);

@GET("lists/{listDbId}")
Call<BaseResult<ArrayResult<Lists>>> getListsById(
Call<BaseResult<Lists>> getListById(
@Path("listDbId") String listDbId,
@Query("page") int page,
@Query("pageSize") int pageSize
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package uk.ac.hutton.ics.brapi.resource.germplasm.germplasm;

import java.util.Collection;
import java.util.*;

public class Mcpd
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import uk.ac.hutton.ics.brapi.resource.base.TokenBaseResult;

public abstract class TokenBaseServerResource<T> extends ServerResource
public abstract class TokenBaseServerResource extends ServerResource
{
protected static final String PARAM_PAGE_SIZE = "pageSize";
protected static final String PARAM_CURRENT_PAGE = "pageToken";
Expand All @@ -16,11 +16,6 @@ public abstract class TokenBaseServerResource<T> extends ServerResource
protected int pageSize = Integer.MAX_VALUE;
protected int currentPage = 0;

protected static String toString(Object value)
{
return value == null ? null : Objects.toString(value);
}

@Override
public void doInit()
{
Expand Down Expand Up @@ -52,15 +47,4 @@ public void doInit()
}
}
}

@Get("json")
public abstract TokenBaseResult<T> getJson();

protected Timestamp getTimestamp(Date date)
{
if (date != null)
return new Timestamp(date.getTime());
else
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
public interface BrapiListIndividualItemServerResource
{
@Post
BaseResult<Lists> postJson(String[] ids);
BaseResult<Lists> postListItems(String[] ids);
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
public interface BrapiListIndividualServerResource
{
@Get
BaseResult<ArrayResult<Lists>> getListsById();
BaseResult<Lists> getListsById();

@Put
BaseResult<Lists> putListById(Lists updatedLists);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ public interface BrapiSeasonServerResource
BaseResult<ArrayResult<Season>> getSeasons();

@Post
BaseResult<ArrayResult<Season>> postSeason(Season[] newSeasons);
BaseResult<ArrayResult<Season>> postSeasons(Season[] newSeasons);
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
public interface BrapiServerInfoResource
{
@Get
BaseResult<ServerInfo> getServerInfo();
BaseResult<ServerInfo> getServerinfo();
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
public interface BrapiVariantServerResource
{
@Get
TokenBaseResult<ArrayResult<Variant>> getVariants();
TokenBaseResult<ArrayResult<Variant>> getAllVariants();
}

0 comments on commit 43e5315

Please sign in to comment.