Cleanup README.md: Fixing some typos/bugs and etc. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erall helping make it more informative.
patricknelson
commented
Jun 6, 2023
patricknelson
changed the title
patricknelson
changed the title
|
Sorry, tinkering with draft/WIP feature. |
patricknelson
commented
Jun 6, 2023
| @@ -25,21 +23,27 @@ npm install svelte-tag | |||
| ``` | |||
|
|
|||
| ```javascript | |||
| import Component from "svelte-tag" | |||
| import SvelteTag from "svelte-tag" | |||
There was a problem hiding this comment.
This was an opinionated change. In my defense, not only did I naturally want to name it SvelteTag, but apparently so have others (see dependents). Seems natural 😊, e.g. https://github.com/souriya777/elegant-seo-website/blob/main/_dev/src/js/svelte-elements.js
patricknelson
commented
Jun 12, 2023
| import App from "your-app.svelte" | ||
| new Component({component:App,tagname:"hello-world",href="/your/stylesheet.css",attributes:["name"]}) | ||
|
|
||
| new SvelteTag({ |
There was a problem hiding this comment.
p.s. @crisward It didn’t notice this until a fair bit later after this PR, but it turns out the use of new here is not necessary at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup README.md:
Preview the way it looks here: https://github.com/patricknelson/svelte-tag/tree/adjust-readme