Skip to content

Conversation

@nmobregon
Copy link

I needed it for a client's implementation. Would be great to have it included in the original

FULL EXAMPLE

<round-progress
      [current]="current"
      [max]="max"
      [stroke]="stroke"
      [radius]="radius"
      [semicircle]="semicircle"
      [rounded]="rounded"
      [responsive]="responsive"
      [clockwise]="clockwise"
      [gradStartColor]="'#7573ab'"
      [gradEndColor]="'#aabbcc'"
      [gradDirection]="'right'"
      [background]="background"
      [duration]="duration"
      [animation]="animation"
      [animationDelay]="animationDelay"></round-progress>

Thanks!
Best regards

Copy link
Owner

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, however in general I try to avoid having multiple ways of doing the same thing and in this case people can already do this by defining the gradient themselves and passing it in as the stroke color.

Furthermore, it makes the API a little more confusing, because the gradient and the stroke color are mutually exclusive, but there's nothing stopping a consumer from setting both of them on the same element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants