Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in datacube extension. #33

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Conversation

huard
Copy link
Collaborator

@huard huard commented Nov 15, 2023

  • Add test.
  • Add schema for local validation.

@huard huard requested review from dchandan and fmigneault November 15, 2023 16:07
@huard
Copy link
Collaborator Author

huard commented Nov 15, 2023

So the tests run fine locally, and I don't quite understand why the datacube one fails on the CI.

@huard
Copy link
Collaborator Author

huard commented Nov 15, 2023

I traced the problem to pystac. Works with 1.8.3, fails with 1.9.0.

@dchandan
Copy link
Collaborator

dchandan commented Nov 16, 2023 via email

@huard
Copy link
Collaborator Author

huard commented Nov 16, 2023

I don't have permission to merge, let me know if there's anything else to modify.

@dchandan
Copy link
Collaborator

I also can't seem to merge anymore. @fmigneault did you make any aches changes after taking over from Mathieu? Please give David and I elevated permissions.

@fmigneault
Copy link
Collaborator

You should both be able to merge as long as there was 1 review approval from someone else.

@fmigneault fmigneault merged commit 341349f into crim-ca:master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants