Skip to content

Commit

Permalink
adding pyessv-archive as submodule
Browse files Browse the repository at this point in the history
  • Loading branch information
@dchandan
dchandan committed Nov 8, 2023
1 parent 9cd2ced commit 59c9b36
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "pyessv-archive"]
path = pyessv-archive
url = https://github.com/dchandan/pyessv-archive
1 change: 1 addition & 0 deletions pyessv-archive
Submodule pyessv-archive added at 32175d

2 comments on commit 59c9b36

@fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented on 59c9b36 Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dchandan
I don't recommend using submodules. Many times, people do not include the git clone --recurse-submodules option, which creates broken installs, and otherwise, unnecessarily duplicates local code. Instead, use a GitHub URL with a specific commit if needed in your pyproject or requirements.txt dependencies.

@dchandan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I like that idea. I needed a way to overcome the issue that the upstream pyessv-archive project had issues with its controlled vocabulary and it seemed that the project (along with other ES-DOC) projects seem essentially abandoned. I will use my fork of pyessv-archive, where I fix the CV issues, for this project.

Please sign in to comment.