pr changes

crim-ca · Oct 27, 2023 · 323c945 · 323c945
1 parent f540dbe
commit 323c945
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/STACpopulator/populator_base.py b/STACpopulator/populator_base.py
@@ -69,18 +69,18 @@ def collection_id(self) -> str:
     def item_properties_model(self):
         """In derived classes, this property should be defined as a pydantic data model that derives from
         models.STACItemProperties."""
-        pass
+        raise NotImplementedError
 
     @property
     @abstractmethod
     def item_geometry_model(self):
         """In derived classes, this property should be defined as a pydantic data model that derives from
         models.STACItemProperties."""
-        pass
+        raise NotImplementedError
 
     @abstractmethod
     def create_stac_item(self, item_name: str, item_data: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
-        pass
+        raise NotImplementedError
 
     def validate_host(self, stac_host: str) -> str:
         if not url_validate(stac_host):

diff --git a/tests/ref.txt → tests/ref.json b/tests/ref.txt → tests/ref.json
diff --git a/tests/test_standalone_stac_item.py b/tests/test_standalone_stac_item.py
@@ -24,7 +24,7 @@ def test_standalone_stac_item():
     stac_item_id = make_cmip6_item_id(attrs["attributes"])
     stac_item = STAC_item_from_metadata(stac_item_id, attrs, CMIP6ItemProperties, GeoJSONPolygon)
 
-    with open("tests/ref.txt", "r") as ff:
+    with open("tests/ref.json", "r") as ff:
         reference = json.load(ff)
 
     assert stac_item.to_dict() == reference