Skip to content

SAML post to correct URL and make example run locally #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adricasti
Copy link

Hi Ross, very useful project, I made three changes to make the example work:

  • The IdP should post the authentication form to URLSSO, not URLLogin, otherwise the flow stops there
  • I fixed the URLs for the example service so it runs in localhost to start with and without conflicting ports for SP and IdP
  • The ServeMux in Go 1.24+ can't identify correct routes and we also need to be able to POST to /saml

@adricasti adricasti requested a review from crewjam as a code owner May 2, 2025 09:52
@crewjam
Copy link
Owner

crewjam commented May 5, 2025

This is looking good. I'm not sure if it is quite ready to merge yet, but I'm down when it is. Let me know if you want more detailed feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants