Fix tool propagation bug in hierarchical crews (#3679) #3680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
- Remove check_tools validator from task.py that was extending task.tools with agent.tools at creation time - This caused manager agents in hierarchical crews to incorrectly inherit tools from task agents - The crew.py execution logic already handles tool resolution correctly at execution time via fallback: task.tools or agent_to_use.tools or [] - Add reproduction test test_hierarchical_crew_does_not_propagate_agent_tools_to_manager - Update test_task_tool_reflect_agent_tools to verify execution-time behavior Fixes #3679 Co-Authored-By: João <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove unused 'crew' variable in test_hierarchical_crew_does_not_propagate_agent_tools_to_manager (F841) - Add raw string prefixes to regex patterns to comply with RUF043 linting rule - Pre-existing RUF043 errors in changed files were blocking PR, so fixed them Co-Authored-By: João <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tool propagation bug in hierarchical crews (#3679)
Summary
This PR fixes a bug where tools were unintentionally propagated to manager agents in hierarchical crews. The root cause was the
check_toolsvalidator intask.pythat automatically extendedtask.toolswithagent.toolsat task creation time. In hierarchical crews, this caused manager agents to inherit tools from task agents when executing those tasks.Key changes:
check_toolsmodel validator fromTaskclasstask.tools or agent_to_use.tools or [])Review & Testing Checklist for Human
crew.py:884should handle this, but needs verification)task.toolsis empty at creation time, but doesn't test the full execution flow. Verify manager agents don't get unwanted tools during actual task executiontask.toolsbeing populated at creation time rather than execution timeNotes
Risk Assessment: This is a behavior change that shifts tool resolution from creation time to execution time. While the crew execution logic should handle this correctly, there's a risk of unintended side effects in edge cases or external code that depends on the old behavior.
Requested by: João ([email protected]) via Slack
Session: https://app.devin.ai/sessions/917aad46e9844e43abad36f8364ac813
Original Issue: #3679