-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(helmcharts): Add initial helm chart for plutono #75
Conversation
This chart was already created by @sabavivek in credativ/helmcharts but it makes sense to streamline the charts to their corresponding project repository. Sponsored-by: @sabavivek Author: @sabavivek Fixes: #57
maintainers: | ||
- name: credativ | ||
version: 0.1.0 | ||
appVersion: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion should be set to the current version.
|
||
## See `kubectl explain poddisruptionbudget.spec` for more | ||
## ref: https://kubernetes.io/docs/tasks/run-application/configure-pdb/ | ||
podDisruptionBudget: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling podDisruptionBudget doesn't do anything. The template is missing.
## Use an existing ClusterRole/Role (depending on rbac.namespaced false/true) | ||
# useExistingRole: name-of-some-role | ||
# useExistingClusterRole: name-of-some-clusterRole | ||
pspEnabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PSP options and the corresponding templates should be deleted since support has been removed in Kubernetes v1.25.
logs: /var/log/plutono | ||
plugins: /var/lib/plutono/plugins | ||
provisioning: /etc/plutono/provisioning | ||
analytics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analytics
should be removed. Not supported by Plutono.
check_for_updates: true | ||
log: | ||
mode: console | ||
plutono_net: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't exist and should be removed.
# -- The Docker registry | ||
registry: docker.io | ||
# image-renderer Image repository | ||
repository: plutono/plutono-image-renderer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image does not exists. It's probably best to just remove image renderer entirely.
|
||
# Enable backward compatibility of kubernetes where version below 1.13 doesn't have the enableServiceLinks option | ||
enableKubeBackwardCompatibility: false | ||
useStatefulSet: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding template is missing.
## | ||
persistence: | ||
type: pvc | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding template is missing.
feature(helmcharts): Add initial helm chart for plutono
This chart was already created by @sabavivek in credativ/helmcharts but it makes sense to streamline the charts to their corresponding project repository.
Sponsored-by: @sabavivek
Author: @sabavivek
Fixes: #57