Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-scroll-to-top-feature(#54) #183

Closed

Conversation

Asheklm6
Copy link
Contributor

@Asheklm6 Asheklm6 commented Oct 12, 2024

Fixes

Description

This PR implements a scroll-to-top button that becomes visible after the user scrolls down a certain distance on the page, improving navigation for users.

Technical details

Added a scroll-to-top button in index.html.
Styled the button using CSS in style.css to ensure it appears fixed at the bottom right of the screen.
The button is initially hidden and designed to appear after scrolling down.

Tests

Open index.html in a browser.
Scroll down the page to verify that the button appears after scrolling down

Screenshots

Scroll before.
Screenshot (111)

Scroll After

Screenshot (112)

Checklist

  • [x ] My pull request has a descriptive title (not a vague title like Update index.md).
  • [x ] My pull request targets the default branch of the repository (main or master).
  • [ x] My commit messages follow best practices.
  • [x ] My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [ x] I added or updated documentation (if applicable).
  • [ x] I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Asheklm6 Asheklm6 requested review from a team as code owners October 12, 2024 10:15
@Asheklm6 Asheklm6 requested review from TimidRobot, possumbilities, MuluhGodson and kgodey and removed request for a team October 12, 2024 10:15
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit eeb937a
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670d1ca9bc1ca5000892cc71
😎 Deploy Preview https://deploy-preview-183--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SisiVero
Copy link
Contributor

SisiVero commented Oct 12, 2024

hi @Asheklm6 , well done.
where you have "Fixes #[54] by @[asheklm6]", remove the "[" and "]" . just write #54 so as to link your PR to the issue #54 that you're about to fix.
Also instead of your username "@[asheklm6]" write @possumbilities as she is the one that opened the issue.
You're doing great. Well done.

@Asheklm6
Copy link
Contributor Author

@SisiVero I've made the changes as you suggested. I've updated the PR description to remove the brackets around the issue number and replaced my username with @possumbilities. Thank you for your guidance . Please let me know if there's anything else I should adjust.

@SisiVero
Copy link
Contributor

@Asheklm6 , well done.
Your PR details are okay now.
@possumbilities is in charge of reviewing PRs and will have a look at it by Monday.

@@ -1025,5 +1025,13 @@ <h1>Name</h1>
document.querySelectorAll("code.lang-html").forEach(el => el.innerText = el.innerHTML);
</script>


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space added.




Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOF character

@possumbilities
Copy link
Contributor

Hi @Asheklm6 thank you for working on this!

The feature in question is for the Vocabulary UX, not the docs. You've added this element to the docs instead.

Your solution here would need to be added to the Vocabulary contexts themselves, not the documentation.

@Asheklm6 Asheklm6 closed this by deleting the head repository Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add a scroll-to-top element to UX for longer page contexts
3 participants