-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-scroll-to-top-feature(#54) #183
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi @Asheklm6 , well done. |
@SisiVero I've made the changes as you suggested. I've updated the PR description to remove the brackets around the issue number and replaced my username with @possumbilities. Thank you for your guidance . Please let me know if there's anything else I should adjust. |
@Asheklm6 , well done. |
@@ -1025,5 +1025,13 @@ <h1>Name</h1> | |||
document.querySelectorAll("code.lang-html").forEach(el => el.innerText = el.innerHTML); | |||
</script> | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space added.
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing EOF character
Hi @Asheklm6 thank you for working on this! The feature in question is for the Vocabulary UX, not the docs. You've added this element to the docs instead. Your solution here would need to be added to the Vocabulary contexts themselves, not the documentation. |
Fixes
Description
This PR implements a scroll-to-top button that becomes visible after the user scrolls down a certain distance on the page, improving navigation for users.
Technical details
Added a scroll-to-top button in index.html.
Styled the button using CSS in style.css to ensure it appears fixed at the bottom right of the screen.
The button is initially hidden and designed to appear after scrolling down.
Tests
Open index.html in a browser.
Scroll down the page to verify that the button appears after scrolling down
Screenshots
Scroll before.
Scroll After
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin