-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search in listings #37
Conversation
8c9d5bc
to
45db2e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, other than the minor comment I made.
I recommend looking into https://github.com/carltongibson/django-filter for more extensible search/filters. You can use a FilterSet
to automatically generate filterable models, see https://django-filter.readthedocs.io/en/master/ref/filterset.html
@kgodey I looked to Although I think it may be useful for the filtering by tags and push filter code on a file apart from |
45db2e1
to
77df346
Compare
@krysal that makes sense, I'll approve once you update the variable name. |
Done :) |
Description
This PR enables the search input of each listing. Initially, search for the user input in these fields:
Deployment preview
See https://caselaw-mirr-feature-se-gqlssn.herokuapp.com/
Check for
/cases
&/scholarship
paths.Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin