Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA attribute added to website for accessibility #336

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SisiVero
Copy link
Contributor

Fixes

Description

This PR addresses the issue of adding ARIA to the website to enhance accessibility.

Tests

ARIA were added to the necessary files accordingly.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SisiVero SisiVero requested a review from a team as a code owner October 11, 2024 22:23
@SisiVero SisiVero requested review from TimidRobot and Shafiya-Heena and removed request for a team October 11, 2024 22:23
@Murdock9803 Murdock9803 requested review from possumbilities and Murdock9803 and removed request for TimidRobot and Shafiya-Heena October 12, 2024 04:17
@Murdock9803
Copy link
Member

Looks good to me,
@possumbilities Is this sufficient in comparison to what we were expecting from ARIA addition ?

@SisiVero
Copy link
Contributor Author

Thank you @Murdock9803


<nav class="ancilliary-menu">
<nav class="ancilliary-menu" role="navigation" aria-label="Main menu">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label is incorrect, it should bw Ancillary Menu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a current open issue on this, pr has been created to address this issue from vocabulary repo.

@possumbilities
Copy link
Contributor

Hi @SisiVero There's a lot of work here and after starting to review it I believe there's a distinction worth putting here. Work here would need to be on items held within the content area of the cc-resource-archive pages. The global header and global footer, if they could do with improvements related to ARIA, that is work that should be documented as an Issue on the main Vocabulary repository, and then done via PRs there.

We don't want the header/footer forking from upstream here.

@SisiVero
Copy link
Contributor Author

SisiVero commented Oct 14, 2024

Okay, @possumbilities , I think there is an open issue on that currently, I'll verify.
If there isn't, I can go ahead and open one, yes?
I'll ho ahead and fix the ones specifically for this repo.

@possumbilities
Copy link
Contributor

@SisiVero If you believe its not covered there, please feel free to.

@SisiVero
Copy link
Contributor Author

Hi @possumbilities , i've removed the aria attributes from the footer and header. do review and get back to me, thank you.

@SisiVero
Copy link
Contributor Author

Hi @possumbilities , after going through the resources shared by @TimidRobot , I realized that there were lots of duplication of texts.
I have made some changes to the files and it seems only one particular element in a file needed an aria-label.
This element might still do without it.
Could you review these changes when you can? We can come to a conclusion on whether to leave it or leave it out entirely.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Introduce ARIA attributes to the website for accessibility
3 participants