Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added display text to the website when there are no matches to the filter. #329

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Queen-codes
Copy link
Contributor

Fixes

Description

This pull request addresses the issue where no resources are displayed when certain filters are applied. With this PR, there is a message being displayed indicating that no resources are available for the selected filters, preventing any user confusion.

Technical details

  • I added a function noResourcesText in listing.js to check if any resources are available based on the selected filters.
  • A text ("No resources are matching these filters") is displayed when no matching resources are found.
  • message is hidden when at least one resource is displayed on the screen.

Tests

I viewed the website in my localhost after implementing changes and ensured the text was displayed only when selected filters don't have a respective resource available.

Screenshots

Problem
Screenshot 2024-10-04 at 13 39 36

Solution
Screenshot 2024-10-04 at 13 15 53

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested a review from a team as a code owner October 4, 2024 12:50
@Queen-codes Queen-codes requested review from TimidRobot and possumbilities and removed request for a team October 4, 2024 12:50
@Murdock9803 Murdock9803 requested review from Murdock9803 and removed request for TimidRobot October 5, 2024 06:20
@Murdock9803
Copy link
Member

@Queen-codes the gemfile.lock file needs to be there in the codebase. For more context - context

@Queen-codes
Copy link
Contributor Author

@Queen-codes the gemfile.lock file needs to be there in the codebase. For more context - context

ohhhh. i understand now. i completely misunderstood. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] display a message when no resources are found matching the filters
2 participants