-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #303. Replaced dynamic styling with class-based CSS approach. #323
Conversation
@poojatalele you should make more descriptive Pull Requests. The fields are almost all empty. You can remove them if not necessary. |
docs/Gemfile.lock
Outdated
@@ -270,6 +270,7 @@ GEM | |||
PLATFORMS | |||
aarch64-linux | |||
arm64-darwin-23 | |||
x86_64-linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an additional change which should be reverted. The Gemfile.lock
file is not the target here i believe.
Updated all the changes, kindly review. @Murdock9803 |
@poojatalele thank you for this contribution! After looking through there are some improvements that could be made to streamline it a bit further. Since the default state is visible, we don't need a For a somewhat similar example of approach see the |
Okay, got it! I'll update the changes. |
@poojatalele Thank you! 👍 |
@Murdock9803 @possumbilities Replaced |
The changes here break the function of the filters after recent UX work. Closing, and would suggest it be revisitied with current work merged in. |
Fixes
Description
This PR addresses the issue where dynamic styling was being used to control the visibility of resource cards in the _assets/js/listing.js file. To enhance maintainability and consistency, the following updates were made:
Introduced new CSS utility classes (.hidden and .visible) to handle the visibility of resource elements without relying on dynamically injected styles.
Refactored the updateVisibility function to utilize these new classes, ensuring that elements are shown or hidden based on the user's filter selections (topic, medium, language).
Adjusted the resource navigation filters to dynamically apply the appropriate visibility classes, providing a cleaner and more efficient way to control the display of filters.
These changes align with the suggestion to replace dynamic styling with a class-based approach, making the codebase more consistent and easier to maintain.
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin