Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scroll to top button #263

Closed
wants to merge 2 commits into from
Closed

Conversation

vivitt
Copy link
Contributor

@vivitt vivitt commented Apr 22, 2024

Fixes

Description

Included a link element in the listing layout to allow users to quickly navigate to the top of the page.

This element targets an anchor tag in the page header and is styled to match the existing 'download resource' button's styling.

JavaScript functionality has been implemented in scroll.js to dynamically display the 'scroll to top' button only when the scroll position is greater than 400px.

Note that, in order to avoid duplication in style.css, the shared styles for '.downloadbutton' and '.backtotopbutton' were extracted into a new CSS class '.button'.

Screenshots

Before

before

After

after

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

vivitt added 2 commits April 22, 2024 16:10
Include a scroll to top link element in the listing layout.
Add css styles matching the existing button's styling.
Listen for scroll events to show or hide the new button.
Create a new .button class with the .downloadbutton and .backtotopbutton shared styles

 Please enter the commit message for your changes. Lines starting
@vivitt vivitt requested a review from a team as a code owner April 22, 2024 14:57
@vivitt vivitt requested review from TimidRobot and Shafiya-Heena and removed request for a team April 22, 2024 14:57
@possumbilities
Copy link
Contributor

Closing this and moving the area of focus to Vocabulary.

@possumbilities possumbilities added ⛔️ status: discarded Will not be worked on 💻 aspect: code Concerns the software code in the repository labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ⛔️ status: discarded Will not be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Add a scroll back to top button
3 participants