Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160 : Jekyll local development setup on the readme file #245

Closed
wants to merge 4 commits into from

Conversation

das123s
Copy link
Contributor

@das123s das123s commented Mar 29, 2024

Fixes

Fixes #160 by @KrownWealth

Description

Changes on readme file how to setup Jekyll in local

Technical details

local setup of Jekyll

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@das123s das123s requested a review from a team as a code owner March 29, 2024 18:57
@das123s das123s requested review from TimidRobot and annatuma and removed request for a team March 29, 2024 18:57
…d of creativecommons.org home page feature added
@possumbilities
Copy link
Contributor

@das123s Hi! can you please fill out the PR description? If not I'll close this PR (you can always submit a new one with details later if that happens).

@das123s
Copy link
Contributor Author

das123s commented Apr 1, 2024

@das123s Hi! can you please fill out the PR description? If not I'll close this PR (you can always submit a new one with details later if that happens).

Hi @possumbilities I have fill out the PR description. Can you please review the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there shouldn't be changes to this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there shouldn't be changes to this file

@possumbilities
Copy link
Contributor

@das123s this is for an Issue that is still set as status: awaiting triage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these steps go around the docker setup and shouldn't be necessary. If we were to add clarfications here I would think they would need to coincide with how the project works rather than going around the Docker container.

@possumbilities
Copy link
Contributor

Hi! I think in an effort to revert your changes you are accidentally deleting the files instead.

@das123s
Copy link
Contributor Author

das123s commented Apr 1, 2024

Hi! I think in an effort to revert your changes you are accidentally deleting the files instead.

Yes. I will close this PR ..will create fresh PR with changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants