-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Organized with proper indentation and comments #106
Conversation
Hey @Xaid-vfx, there is still a bit more work needed before this PR can be merged. |
Done !! |
Looks good to me. Nice work 😊 |
@Xaid-vfx Usually the head area isn't indented, and a few files might be missing "End of line" characters. Also need to resolve the merge conflicts, but other than that once the above is run through again this would likely be approvable. Well done! |
Hey @possumbilities, |
@Xaid-vfx you may have used an extension for this but the extension hasn't worked properly. The stylesheet link and heading tag should be in a single line and the extension has also added a line after curly brace |
If you view the files tab on this PR you can see a little red circle with a line through it at the end of some of the files: This means it's missing an |
@possumbilities Thank you so much. I'll update this PR asap. |
@possumbilities Since this PR was raised long time back, its branch is 43 commits behind and has a few conflicts. Should I raise a new PR with a new branch (this way all the new code would be organized as well) or just push the changes without merging 43 commits? |
@Xaid-vfx You should be able to work through resolving the merge conflicts and keep this PR. But you can also close this PR and start a fresh one since its so far behind. I'd suggest trying to resolve the conflicts, first though. It should be possible. |
@Xaid-vfx do you intend to resolve the conflicts and move this out of Draft? |
Please create a new PR based on the |
Fixes
Fixes #101 by @Xaid-vfx
Description
The code structure has been arranged in compliance with standard formatting conventions and indentation. Furthermore, comments have been added to specific areas within the code to assist future developers in locating and contributing to it with ease.
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin