Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace the dynamic styling in listing.js with class-based CSS approach #303

Open
1 task done
Murdock9803 opened this issue Jul 3, 2024 · 2 comments
Open
1 task done
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@Murdock9803
Copy link
Member

Problem

In the _assets/js/listing.js file, to make the resources visible, the use of dynamic styling has been done.

Description

Instead of creating a new style element for the displaying of resource cards, It will be better to use a css property of display: none via a class based approach. we can create a new utility class for the task.
The link to listing.js file: https://github.com/creativecommons/cc-resource-archive/blob/main/docs/_assets/js/listing.js

Implementation

  • I would be interested in implementing this feature.
@Murdock9803 Murdock9803 added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jul 3, 2024
@poojatalele
Copy link

I would like to work on this issue, kindly assign.

@poojatalele
Copy link

poojatalele commented Aug 4, 2024

@Murdock9803 Kindly review my pr and let me know if any other changes are required!!

@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 16, 2024
@TimidRobot TimidRobot moved this to Backlog in possumbilities Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
3 participants