Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch ci workflows #55

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Patch ci workflows #55

merged 8 commits into from
Oct 28, 2023

Conversation

feryardiant
Copy link
Contributor

@feryardiant feryardiant commented Oct 28, 2023 •
edited
Loading

PR ini ditujukan sebagai experiment untuk resolve #54, #36 dan #31

Target dari PR ini adalah :

@feryardiant feryardiant added enhancement New feature or request chore A task that needs to be done integration When multiple functionalities should works together labels Oct 28, 2023
@feryardiant feryardiant self-assigned this Oct 28, 2023
@feryardiant feryardiant requested a review from a team October 28, 2023 19:07
@feryardiant
Copy link
Contributor Author

Lha kampret, malah CI gak jalan? 🤦🏻‍♂️

Apa karna trigger pull_request_target itu harus ada di main branch dulu?

hashtag : emosi

@feryardiant
test(ci): rename build workflow to prepare
c0d0d42 
as the name suggests this workflow meant to prepare all things needed
for the next workflows. And in regards of workflow outputs please read
more https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
chore(ci): remove Prepare Environment steps in regard of c0d0d42
7a2358f 
Signed-off-by: Fery Wardiyanto <[email protected]>
This was linked to issues Oct 28, 2023
Migrasi dari husky ke simple-git-hooks #31
Closed
Release Management #36
Closed
@feryardiant
feat(ci): add triage workflow that will triggered on all PR
7a4d33d 
read more about labeling https://github.com/actions/labeler

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
chore(ci): i don't thing label config is necessary
8528f6d 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
feat(ci): add release config
4e7448c 
Let's keep it bare minimum for now with exclution of all PRs by
dependabot

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
feat(ci): add release workflow to add notes from CHANGELOG.md
05f14bd 
The main reason is by default auto release mechanism from github only
gather information from pull request title and there's no way to have
information regarding bug fixes, features and more importantly breaking
changes (if any).

The only way to get those info (at least for now) is only from commit
so please make sure to make a commit message that informative enough
so we could automate the rest.

In this case is which commit message that tent to fix a bug, add features
or breaking changes. Please read conventional commit for more info

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Copy link
Contributor Author

PR ini sebenernya agak merepotkan karna gak bisa langsung di check di PR, tapi perlu merge ke main dulu & bahkan bikin tag dulu untuk memastikan. Dan yang aku terapin disini hanya berdasarkan dokumentasi yang ada dari masing-masing tools.

Jadi ya 🤞🏻

@feryardiant feryardiant merged commit e16a769 into main Oct 28, 2023
@feryardiant feryardiant deleted the patch-ci-workflows branch October 28, 2023 22:07
@feryardiant feryardiant mentioned this pull request Oct 29, 2023
Merged
@sakukode
Copy link

Apa benefit atau dalam hal apa kaitannya penggunaannya dari auto label pada setiap PR?

@feryardiant
Copy link
Contributor Author

Meminimalisir lupa assign label atau assign label yang kurang sesuai dengan scope pekerjaan nya. Dalam hal ini kebutuhan utamanya adalah untuk pembuatan release note. Walaupun aku rasa untuk saat ini masih belum optimal secara aturan, untuk itu aku harap ini jadi langkah awal untuk kita bisa mengoptimalkan mekanisme ini kedepannya.

Belum lama ini aku nemu srvaroa/labeler yang memungkinkan kita gak cuma assign label tapi juga update PR title, contoh. Jadi release note nya gak perlu lagi ambil dari commit message kayak kita sekarang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feryardiant feryardiant

Labels
chore A task that needs to be done enhancement New feature or request integration When multiple functionalities should works together
Projects
Shared Repositories
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependabot gak bisa baca github secrets Release Management Migrasi dari husky ke simple-git-hooks
2 participants
@feryardiant @sakukode