9p: add 9p fuse client #1123

redbeam · 2025-07-04T12:18:07Z

9P support for filesharing on Windows: crc-org/crc#4168

Summary by Sourcery

Enhancements:

Enable mskvarla/9pfs COPR repository and download the 9pfs package in createdisk.sh when generating Windows bundles

Summary by CodeRabbit

New Features
- When creating a Windows bundle, the build now pre-downloads and stages the 9p file-sharing package so it’s available for later installation in the VM, improving Windows 9p support.
Chores
- Improved package preparation flow for Windows bundle creation and clarified comments about which pre-downloaded and additional packages are not installed in the guest.

sourcery-ai · 2025-07-04T12:18:11Z

Reviewer's Guide

This PR enhances the createdisk.sh script to support 9P file sharing on Windows by adding steps that enable a COPR repository and download the 9pfs binary via SSH when generating the Windows bundle, then include it in the installation list.

Flow diagram for 9P FUSE client installation in createdisk.sh

flowchart TD
    A[Start createdisk.sh] --> B{Is SNC_GENERATE_WINDOWS_BUNDLE != 0?}
    B -- No --> C[Continue without 9pfs setup]
    B -- Yes --> D[Enable COPR repo mskvarla/9pfs via SSH]
    D --> E[Create ~/packages directory via SSH]
    E --> F[Download 9pfs package to ~/packages via SSH]
    F --> G[Add 9pfs to ADDITIONAL_PACKAGES]
    G --> H[Continue with install_additional_packages]
    C --> H
    H[Install additional packages and copy systemd units]

File-Level Changes

Change	Details	Files
Add logic to install 9pfs during Windows bundle creation	Guard installation steps with SNC_GENERATE_WINDOWS_BUNDLE check Enable mskvarla/9pfs COPR repository on the VM Download the 9pfs package into a local directory Append '9pfs' to ADDITIONAL_PACKAGES for installation	`createdisk.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

coderabbitai · 2025-07-04T12:18:13Z

Walkthrough

The createdisk.sh script was updated to, when generating a Windows bundle, enable the mskvarla/9pfs COPR repo, download the 9pfs package into a local directory, disable the COPR repo, and add 9pfs to PRE_DOWNLOADED_ADDITIONAL_PACKAGES.

Changes

Cohort / File(s)	Change Summary
Disk creation script `createdisk.sh`	Added conditional logic for Windows bundle generation: enable COPR `mskvarla/9pfs`, download `9pfs` to local cache, disable the COPR repo, and append `9pfs` to `PRE_DOWNLOADED_ADDITIONAL_PACKAGES`. Comment updated to include `PRE_DOWNLOADED_ADDITIONAL_PACKAGES`.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant DevEnv as create-disk script
  participant COPR as COPR (mskvarla/9pfs)
  participant Cache as Local cache dir
  participant VMPrep as install_additional_packages step

  rect rgb(230, 248, 255)
    DevEnv->>COPR: enable repo (if Windows bundle)
    DevEnv->>COPR: dnf download 9pfs --downloaddir=Cache
    COPR-->>DevEnv: provide 9pfs package
    DevEnv->>COPR: disable repo
    DevEnv->>DevEnv: append '9pfs' to PRE_DOWNLOADED_ADDITIONAL_PACKAGES
  end

  DevEnv->>VMPrep: call install_additional_packages (uses pre-downloaded packages)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

9P File sharing crc#4858 — Matches intent to pre-download 9pfs from mskvarla/9pfs COPR for inclusion in Windows bundle; this PR implements that pre-download step.

Poem

A rabbit hopped in bash and cheer,
Enabled COPR to fetch what’s near,
Saved 9pfs for Windows’ share,
Cached it neatly with careful care,
Now disks are built with files to spare. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly indicates the addition of the 9p fuse client, which matches the core enhancement implemented in createdisk.sh for Windows bundle support. It uses clear and consistent terminology that aligns with the PR objectives and code changes. The phrasing is concise and specific enough to inform readers of the main change at a glance.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch add_9p_fuse_client

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebb66cd and fc6975d.

📒 Files selected for processing (1)

createdisk.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

createdisk.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2025-07-04T12:18:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai

Hey @redbeam - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60549d2 and 089c041.

📒 Files selected for processing (1)

createdisk.sh (1 hunks)

createdisk.sh

redbeam · 2025-07-04T12:22:17Z

/hold

redbeam · 2025-08-06T09:11:29Z

/unhold

createdisk.sh

anjannath · 2025-09-29T06:50:00Z

/test e2e-snc

praveenkumar · 2025-10-03T04:51:51Z

@redbeam both commit should be squashed because you are replacing container build binary to rpm based one.

This adds the necessary steps for installation of the 9pfs client to the hyperv image. The binary is installed from a COPR repository. This binary is needed to enable 9P file sharing.

redbeam self-assigned this Jul 4, 2025

redbeam added this to Project planning: crc Jul 4, 2025

openshift-ci bot requested review from anjannath and cfergeau July 4, 2025 12:18

sourcery-ai bot reviewed Jul 4, 2025

View reviewed changes

redbeam changed the title ~~add 9p fuse client~~ 9p: add 9p fuse client Jul 4, 2025

coderabbitai bot reviewed Jul 4, 2025

View reviewed changes

createdisk.sh Show resolved Hide resolved

redbeam moved this to Hold in Project planning: crc Jul 4, 2025

openshift-ci bot added the do-not-merge/hold label Jul 4, 2025

redbeam force-pushed the add_9p_fuse_client branch 2 times, most recently from ce67106 to ab5803b Compare July 9, 2025 13:09

redbeam mentioned this pull request Jul 9, 2025

installing additional packages fails if repository is enabled only in the VM #1124

Closed

redbeam force-pushed the add_9p_fuse_client branch 2 times, most recently from a737705 to ebb66cd Compare July 16, 2025 09:32

redbeam mentioned this pull request Jul 27, 2025

9P File sharing crc-org/crc#4858

Open

redbeam mentioned this pull request Aug 6, 2025

9p file sharing crc-org/crc#4866

Open

1 task

openshift-ci bot removed the do-not-merge/hold label Aug 6, 2025

redbeam moved this from Hold to Ready for review in Project planning: crc Aug 6, 2025

praveenkumar reviewed Aug 11, 2025

View reviewed changes

createdisk.sh Show resolved Hide resolved

9p: steps for 9pfs binary installation in hyperv image

fc6975d

This adds the necessary steps for installation of the 9pfs client to the hyperv image. The binary is installed from a COPR repository. This binary is needed to enable 9P file sharing.

redbeam force-pushed the add_9p_fuse_client branch from ebb66cd to fc6975d Compare October 4, 2025 00:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

9p: add 9p fuse client #1123

9p: add 9p fuse client #1123

Uh oh!

redbeam commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

sourcery-ai bot commented Jul 4, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Jul 4, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

redbeam commented Jul 4, 2025

Uh oh!

redbeam commented Aug 6, 2025

Uh oh!

Uh oh!

anjannath commented Sep 29, 2025

Uh oh!

praveenkumar commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

9p: add 9p fuse client #1123

Are you sure you want to change the base?

9p: add 9p fuse client #1123

Uh oh!

Conversation

redbeam commented Jul 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Summary by CodeRabbit

Uh oh!

sourcery-ai bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Flow diagram for 9P FUSE client installation in createdisk.sh

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Poem

Pre-merge checks and finishing touches

Uh oh!

openshift-ci bot commented Jul 4, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

redbeam commented Jul 4, 2025

Uh oh!

redbeam commented Aug 6, 2025

Uh oh!

Uh oh!

anjannath commented Sep 29, 2025

Uh oh!

praveenkumar commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

redbeam commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

sourcery-ai bot commented Jul 4, 2025 •

edited

Loading

coderabbitai bot commented Jul 4, 2025 •

edited

Loading