verify-vendor.sh: fix early exit on non-zero exit code

[redbeam]

If git diff --exit-code vendor go.mod go.sum found a difference, it exited with exit code 1 and caused the whole script to exit prematurely due to set -o errexit, skipping the printing of the final message to the user.

Summary by CodeRabbit

• Refactor

  • Simplified conditional logic in an internal verification script to reduce redundancy and improve readability. Behavior, messages, and exit codes remain unchanged.

• Chores

  • Maintenance updates to internal tooling to streamline developer workflows. No impact on user-facing functionality or production behavior.

[coderabbitai]

Walkthrough

Refactors a shell script by collapsing a two-step git diff check into a single inline conditional, preserving behavior and exit status handling. Output messages remain effectively the same aside from formatting.

Changes

Cohort / File(s)	Summary
Shell script conditional simplification verify-vendor.sh	Replaced separate git diff call plus $? check with an inline if git diff -- ...; then construct; no functional changes, only streamlined control flow and minor formatting consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A nibble of bash, a hop through diff,
I trimmed the if—so light, so swift.
No change in fate, just cleaner air,
The carrots compile with tidy flair.
Tap-tap, whiskers twitch—approved! ✅
Onward I bound, efficiency proved. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The provided description states the symptom and root cause but does not follow the repository’s template structure, as it lacks the required “Fixes:” reference, type of change checklist, proposed changes details, testing instructions, and contribution checklist sections. This omission makes it difficult for reviewers to see the issue link, understand the scope of changes, and verify test coverage against the standard template.	Please expand the description to include the “Fixes:” or “Relates to:” issue reference, classify the change under “Type of change,” list the specific proposed modifications under “Proposed changes,” outline test cases in the “Testing” section, and complete the “Contribution Checklist” per the repository template.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly names the affected script and clearly describes the primary behavior change—preventing an early exit on a non-zero exit code—which matches the core purpose of the pull request without extraneous detail. It is concise, specific, and directly reflects the main fix implemented.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_verify_vendor

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a7eb0d and 5adcabe.

📒 Files selected for processing (1)

• verify-vendor.sh (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)

• GitHub Check: build-qe (windows, amd64)
• GitHub Check: build-qe (darwin, arm64)
• GitHub Check: build-qe (linux, amd64)
• GitHub Check: build-qe (linux, arm64)
• GitHub Check: build (windows-2022, 1.24)
• GitHub Check: build-qe (darwin, amd64)
• GitHub Check: build (macOS-14, 1.24)
• GitHub Check: build-installer (windows-2022, 1.24)
• GitHub Check: build (ubuntu-latest, 1.24)
• GitHub Check: build (ubuntu-22.04, 1.24)
• GitHub Check: build (ubuntu-latest, 1.24)
• GitHub Check: verify-devcontainer
• GitHub Check: build (windows-2022, 1.24)
• GitHub Check: build (macOS-13, 1.24)
• GitHub Check: Run OKD bundle with crc (1.24)
• GitHub Check: build (macOS-13, 1.24)
• GitHub Check: build (macOS-14, 1.24)
• GitHub Check: Konflux kflux-prd-rh02 / crc-binary-on-pull-request

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anjannath for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@redbeam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	5adcabe	link	false	/test security
ci/prow/e2e-crc	5adcabe	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.