Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: Use ed25519 algorithm instead ECDSA #4304

Merged
merged 2 commits into from
Aug 20, 2024
Merged

ssh: Use ed25519 algorithm instead ECDSA #4304

merged 2 commits into from
Aug 20, 2024

Commits on Aug 8, 2024

  1. ssh: Use ed25519 algorithm instead ECDSA 

    Key generated using ecdsa algorithm is causing issue for podman remote
connection on podman desktop side because the library they consume
doesn't have support for this algorithm. This PR is switching the ecdsa
to ed25519 with openssh type which is supported by the library consumed
in podman desktop.

[0] podman-desktop/podman-desktop#8351
[1] mscdex/ssh2#1375
    @praveenkumar
    praveenkumar committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0dc30b9 View commit details
    Browse the repository at this point in the history

  2. Rename GetRsaPrivateKeyPath to GetECDSAPrivateKeyPath for backward co… 

    …mpatibility

We were using RSA Algo long time ago and this function is used to
provide a backward compatibility for that version of crc but since in
previous commit we have updated the ssh algo from ecdsa to ed25519, to
have the backward compatibility for some released version we are
renaming this function.
    @praveenkumar
    praveenkumar committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8794f8a View commit details
    Browse the repository at this point in the history