-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Function Python v2 #762
Conversation
This is an example of an enrichment process function which consumes events from Event Hub, processes them and insert into CrateDB.
Added the details on how to deploy the Azure Function from VS Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Didn't do a thorough review, but added one little suggestion. I'd also like to change the folder name and add a little software test case, but this can also happen after merging.
topic/Azure function - event hub triggered/Azure Function/requirements.txt
Outdated
Show resolved
Hide resolved
Thanks for making it work with the v2 model! For this to be an example of basic interoperability between CrateDB/Azure Functions, I think we can trim this down quite a bit. The code originates from a specific implementation project that has all sorts of complexity and corner cases. Which I feel we can skip here, trying to make this a concise example showing how easy it is to make the integration work. Examples:
|
…into AF-example
Removed much of the previous logic that only applies to more complex use cases with more transformations.
Submit updates to ReadMe to correspond to the latest simplified version
topic/Azure function - event hub triggered/Azure Function/crate_writer.py
Outdated
Show resolved
Hide resolved
topic/Azure function - event hub triggered/Azure Function/value_cache.py
Outdated
Show resolved
Hide resolved
topic/Azure function - event hub triggered/Azure Function/enrichment.py
Outdated
Show resolved
Hide resolved
topic/Azure function - event hub triggered/Azure Function/function_app.py
Outdated
Show resolved
Hide resolved
topic/Azure function - event hub triggered/Azure Function/value_cache.py
Outdated
Show resolved
Hide resolved
topic/Azure function - event hub triggered/Azure Function/enrichment.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Niklas Schmidtmer <[email protected]>
- Renamed `crate_writer` to `cratedb_writer` Simplified error handling by removing - `error_empty` - ran `black .`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Two more suggestions from my side, feel free to amend.
- Folder name:
topic/serverless/azure-eventhub
. - Squash all commits into a single one.
Restructure folder to comply with repository form.
This is an example of an enrichment process function which consumes events from Event Hub, processes them and insert into CrateDB.
Summary of the changes / Why this is an improvement
Checklist