Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pandas and sqlalchemy #400

Closed
wants to merge 1 commit into from
Closed

Conversation

surister
Copy link
Contributor

@surister surister commented Apr 8, 2024

Summary of the changes / Why this is an improvement

Update pandas and sqlalchemy to latest (or fairly modern versions)

Checklist

@surister
Copy link
Contributor Author

surister commented Apr 8, 2024

Found some issues with Pandas while running all the notebooks, will try to fix later

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack for working on this. There is an error on CI wrt. to PyCaret. I hope it will turn out well. Maybe PyCaret exclusively needs pandas<2 or SQLAlchemy<2?

File /opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/pycaret/internal/memory.py:25
ImportError: cannot import name '_format_load_msg' from 'joblib.memory' (/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/joblib/memory.py)

-- https://github.com/crate/cratedb-examples/actions/runs/8604266577/job/23577980009?pr=400#step:6:859

If this is the case, we may need to split up the ingredients to be separated by pandas/SQLAlchemy major versions in one way or another, either by providing dedicated requirements.txt files, or by separating notebooks into different folders.

@amotl
Copy link
Member

amotl commented Apr 8, 2024

There is an error on CI wrt. to PyCaret: ImportError: cannot import name '_format_load_msg' from 'joblib.memory'.

I discovered the same error here:

This adjustment aims to mitigate it. Effectively, just downgrade to joblib 1.3.

See also:

@amotl
Copy link
Member

amotl commented Apr 9, 2024

There is an error with PyCaret.

There is also a compatibility flaw with Dask and most recent Python 3.11.9, orthogonal to the Joblib 1.4 compatibility issue.

@amotl
Copy link
Member

amotl commented Apr 10, 2024

The TSML stack modulo LLM/LangChain needed two fixes, as outlined above. After rebasing, relevant obstacles should be remedied for you.

@amotl
Copy link
Member

amotl commented Apr 10, 2024

More havocs caused by recent updates had to be remedied, to make relevant artefacts work on Google Colab again. Thanks for your support, @marijaselakovic.

@surister: You may now want to rebase again, to be in a better position than before.

@amotl
Copy link
Member

amotl commented Apr 19, 2024

Hi there. I just rebased your patch, also resolving slight conflicts, and would like to verify it on CI. However, I can't push easily, because you forked the repository into a private one on your account. May I ask you to add corresponding permissions, so I can push, if you are fine with that?

$ git push --force
error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'github.com:surister/cratedb-examples.git'

@amotl
Copy link
Member

amotl commented May 6, 2024

This patch is currently blocked on errors like this, evaluated on behalf of GH-430 1:

TypeError: Could not convert string 'BerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlin' to numeric

-- https://github.com/crate/cratedb-examples/actions/runs/8975962618/job/24651748395?pr=430#step:6:1839

Footnotes

  1. @surister: Feel free to close your PR, and continue working on collab/update-pandas-sqlalchemy, directly from within this repository. It will save you a few cycles on rebasing.

@surister surister closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants