-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of data streaming with apache kafka + apache flink #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job, I love it.
application/apache-kafka-flink-streaming/jars/flink-sql-connector-kafka-3.1.0-1.18.jar
Outdated
Show resolved
Hide resolved
1bee60d
to
df13db1
Compare
df13db1
to
a11deb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent patch, thank you very much. Just added some comments/suggestions about a few nits, and also adding @matriv as reviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few minor suggestions which could be adjusted, approving this. Thanks again!
Thanks for the thorough review, all fixes have been applied 👍 |
About
Illustrate how to use Apache Flink through its PyFlink interface, together with Apache Kafka and CrateDB.