-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploratory data analysis with PyCaret and CrateDB #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this example! I would suggest the following improvements:
- Short intro to PyCaret and why we have chosen it (can be taken, e.g. from the AutoML notebooks).
- Short summary of the kind "what you will learn"
- The file size is very large, maybe some outputs can be shortened?
- For those who just want to scroll over the notebook, please keep the output of the cells and render the diagrams as PNG (similar to https://github.com/crate/cratedb-examples/blob/marija/timeseries-analysis/topic/timeseries/timeseries-queries-and-visualization.ipynb). This might also reduce the file size. Someonw who just scrolls over it, will still get the context without runnign all the code.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks. 18 MB is far too large, right. Please make sure to mitigate all traces of that file from your branch before merging, by amending the existing commit, and by squashing subsequent ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The improvements have been implemented and the size of the file significantly reduced.
…ort_langchain.ipynb Co-authored-by: Andreas Motl <[email protected]>
…ort.ipynb Co-authored-by: Andreas Motl <[email protected]>
Bumps [xunit](https://github.com/xunit/xunit) from 2.6.6 to 2.7.0. - [Commits](xunit/xunit@2.6.6...2.7.0) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cratedb-toolkit[testing]](https://github.com/crate-workbench/cratedb-toolkit) from 0.0.4 to 0.0.5. - [Release notes](https://github.com/crate-workbench/cratedb-toolkit/releases) - [Changelog](https://github.com/crate-workbench/cratedb-toolkit/blob/main/CHANGES.md) - [Commits](crate/cratedb-toolkit@v0.0.4...v0.0.5) --- updated-dependencies: - dependency-name: cratedb-toolkit[testing] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cratedb-toolkit[testing]](https://github.com/crate-workbench/cratedb-toolkit) from 0.0.4 to 0.0.5. - [Release notes](https://github.com/crate-workbench/cratedb-toolkit/releases) - [Changelog](https://github.com/crate-workbench/cratedb-toolkit/blob/main/CHANGES.md) - [Commits](crate/cratedb-toolkit@v0.0.4...v0.0.5) --- updated-dependencies: - dependency-name: cratedb-toolkit[testing] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [langchain-openai](https://github.com/langchain-ai/langchain) from 0.0.5 to 0.0.6. - [Release notes](https://github.com/langchain-ai/langchain/releases) - [Commits](https://github.com/langchain-ai/langchain/commits) --- updated-dependencies: - dependency-name: langchain-openai dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.6 to 2.5.7. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.6...2.5.7) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [plotly](https://github.com/plotly/plotly.py) to permit the latest version. - [Release notes](https://github.com/plotly/plotly.py/releases) - [Changelog](https://github.com/plotly/plotly.py/blob/master/CHANGELOG.md) - [Commits](plotly/plotly.py@jupyterlab-plotly-v1.0.0-alpha.3...v5.19.0) --- updated-dependencies: - dependency-name: plotly dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
will close this PR and open a new one. |
Summary of the changes / Why this is an improvement
Checklist