Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Nov 9, 2025

Problem

It looks like the Testcontainers <-> Junit 5 demo wasn't complete as of #1164: I accidentally converted relevant test cases to use singleton containers instead, which wasn't intended.

Solution

This patch resolves it by adding the org.testcontainers:testcontainers-junit-jupiter extension, and adjusts the two test cases to actually use it, including inline comments and README.

/cc @matriv

@amotl amotl requested review from seut and surister November 9, 2025 20:23
@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch testcontainers-java-more

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl force-pushed the testcontainers-java-more branch from 0ffb323 to c548a4c Compare November 9, 2025 20:39
@amotl amotl merged commit 7abaa2c into main Nov 12, 2025
4 checks passed
@amotl amotl deleted the testcontainers-java-more branch November 12, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants