Skip to content

Improve metadata bwc test - FDW #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2025
Merged

Improve metadata bwc test - FDW #355

merged 1 commit into from
Oct 25, 2025

Conversation

@jeeminso
Copy link
Contributor

@jeeminso jeeminso commented Jun 2, 2025 •
edited
Loading

Summary of the changes / Why this is an improvement

Relates #341

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???

@jeeminso
Copy link
Contributor Author

jeeminso commented Jun 2, 2025

Noticed that CrateDB allows to CREATE SERVER but provide host/port of its own, and allow creating a foreign table of local table. But should not be a problem, other than hard to figure out what was going on.

@jeeminso jeeminso marked this pull request as ready for review June 2, 2025 22:51
@jeeminso jeeminso requested a review from mfussenegger June 2, 2025 22:51
@seut
Copy link
Member

seut commented Jun 3, 2025

Noticed that CrateDB allows to CREATE SERVER but provide host/port of its own, and allow creating a foreign table of local table. But should not be a problem, other than hard to figure out what was going on.

It's expected behaviour that the crate user can create a foreign table against itself, see the note at https://cratedb.com/docs/crate/reference/en/latest/admin/fdw.html#jdbc.

@jeeminso jeeminso requested review from matriv and removed request for mfussenegger July 31, 2025 23:24
@jeeminso
Copy link
Contributor Author

Hi @matriv could you review this?

matriv
matriv approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left just one comment regarding naming.

tests/bwc/test_rolling_upgrade.py Outdated
}
cluster = self._new_cluster(path.from_version, nodes, settings=settings)
cluster.start()
replica_cluster = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call it replica, maybe foreign_cluster? replica is misleading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about remote_cluster? since I will re-use it for logical replication.

@jeeminso jeeminso force-pushed the jeeminso/fdw branch 4 times, most recently from 5deb4fb to c87366e Compare October 24, 2025 00:36
@jeeminso
Copy link
Contributor Author

Hi @matriv could you do a quick review? Since the last approval, I have only resolved the conflicts.

@jeeminso jeeminso requested a review from matriv October 24, 2025 00:54
matriv
matriv approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@jeeminso jeeminso merged commit 537b7c8 into master Oct 25, 2025
1 check passed
@jeeminso jeeminso deleted the jeeminso/fdw branch October 25, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matriv matriv matriv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeeminso @seut @matriv