Remove grand-central tables before restoring a full snapshot #782
+482
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaharanne
force-pushed
the
p/restore-snapshot-with-gc
branch
5 times, most recently
from
b4dd6ae to
a0eeecb
Compare
juanpardo
reviewed
Oct 17, 2025
crate/operator/restore_backup.py
Outdated
| partitions, | ||
| sections, | ||
| ) | ||
| except kopf.PermanentError as e: |
There was a problem hiding this comment.
Really nice strategy to ensure a consistent state. But I guess any exception should call the restore_tables function, right? If any other error that you have not captured and dealt with raises an exception it should still restore.
There was a problem hiding this comment.
I've changed it to Exception to catch everything
|
@plaharanne I am wondering if Grand Central is being turned off during this process. I hope so because I think it is necessary, otherwise it may crash or recreate the tables. I searched a bit but didn't find anywhere whether GC is shutdown during backup restoration |
fix uppercase in test add debug logs change query to get gc tables debug on dev fix table name in query
plaharanne
force-pushed
the
p/restore-snapshot-with-gc
branch
from
7162bb1 to
42d34e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
If the type of restore is
allortableswith gc tables in the list, check if the snapshot contains grand central tables and temporary rename them before executing theRESTOREquery.When the snapshot is restored, either drop the old gc tables or rename them back if it failed.
Checklist
CHANGES.rst