Cleaning#53
Merged
AbdelrhmanBassiouny merged 17 commits intocram2:mainfrom Dec 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a substantial cleanup of the entity query language (EQL) codebase by removing wrapper classes and unused methods to simplify the type system and reduce indirection. The refactoring streamlines value handling throughout the system by eliminating the HashedValue wrapper in most places while confining HashedIterable usage to Variable domains only.
Key changes:
- Removed
HashedValuewrapper from operation bindings, changing type signatures fromDict[int, HashedValue]toDict[int, Any]throughout - Eliminated the
Fromclass wrapper, using domain values directly asDomainType(Union[Iterable, None]) - Removed unused classes (
Infer), methods (_projection_,_is_duplicate_output_), andHashedIterablehelper methods
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/krrood_test/test_eql/test_indexing.py |
Removed unused From import |
test/krrood_test/test_eql/test_core/test_queries.py |
Updated test to use a() instead of an() and removed .value access from sources assertion |
krrood/src/krrood/entity_query_language/utils.py |
Updated comments to reflect removal of HashedValue wrapper |
krrood/src/krrood/entity_query_language/symbolic.py |
Core refactoring: removed HashedValue wrappers from bindings, removed From class, removed unused methods, updated type signatures, moved DomainType definition here, simplified _unique_variables_ to return Set[Variable] |
krrood/src/krrood/entity_query_language/match.py |
Updated imports to get DomainType from symbolic module, updated type signatures |
krrood/src/krrood/entity_query_language/hashed_data.py |
Removed most HashedIterable helper methods (get, add, update, map, filter, union, intersection, etc.) leaving only minimal iterator functionality |
krrood/src/krrood/entity_query_language/entity.py |
Removed From class and DomainType definition, updated to import from symbolic module |
krrood/src/krrood/entity_query_language/conclusion_selector.py |
Removed _projection_ method, simplified variable filtering using set comprehensions instead of HashedIterable.filter() |
krrood/src/krrood/entity_query_language/conclusion.py |
Removed Infer class, updated type signatures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LucaKro
reviewed
Dec 7, 2025
tomsch420
requested changes
Dec 8, 2025
Julislz
referenced
this pull request
in SUTURO/cognitive_robot_abstract_machine
Dec 8, 2025
Fixed inheritance of generated tables.
sunava
pushed a commit
to sunava/cognitive_robot_abstract_machine
that referenced
this pull request
Apr 7, 2026
…merged PR: M3 sprint8 - pickup place marc merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashedValuecompletely.HashedIterable, renamed it toReEnterableLazyIterable, and moved it to cache_data.py._is_duplicate_output_,_projection_)Infer,From)_domain_ofVariable.