Handle scenario where a repo doesn't have any coverage (#776)

craigatk · May 28, 2022 · bbaaf1b · bbaaf1b
1 parent b7d2ad6
commit bbaaf1b
Show file tree

Hide file tree

Showing 2 changed files with 84 additions and 16 deletions.
diff --git a/ui/src/Organization/Coverage/OrganizationCoverageDetails.tsx b/ui/src/Organization/Coverage/OrganizationCoverageDetails.tsx
@@ -24,22 +24,24 @@ const OrganizationCoverageDetails = ({
   const classes = useStyles({});
 
   if (organizationCoverage) {
-    const coverageTableRows = organizationCoverage.repositories.map(
-      (repositoryCoverage) =>
-        ({
-          name: repositoryCoverage.projectName
-            ? `${repositoryCoverage.repoName} ${repositoryCoverage.projectName}`
-            : repositoryCoverage.repoName,
-          stats: repositoryCoverage.coverage.overallStats,
-          previousTestRunId: repositoryCoverage.coverage.previousTestRunId,
-          nameLinkUrl: repositoryLinkUrlUI(
-            repositoryCoverage.repoName,
-            repositoryCoverage.projectName,
-            null
-          ),
-          coveredPercentageLink: `/tests/${repositoryCoverage.publicId}/`,
-        } as CoverageTableRow)
-    );
+    const coverageTableRows = organizationCoverage.repositories
+      .filter((repositoryCoverage) => repositoryCoverage.coverage != null)
+      .map(
+        (repositoryCoverage) =>
+          ({
+            name: repositoryCoverage.projectName
+              ? `${repositoryCoverage.repoName} ${repositoryCoverage.projectName}`
+              : repositoryCoverage.repoName,
+            stats: repositoryCoverage.coverage.overallStats,
+            previousTestRunId: repositoryCoverage.coverage.previousTestRunId,
+            nameLinkUrl: repositoryLinkUrlUI(
+              repositoryCoverage.repoName,
+              repositoryCoverage.projectName,
+              null
+            ),
+            coveredPercentageLink: `/tests/${repositoryCoverage.publicId}/`,
+          } as CoverageTableRow)
+      );
 
     return (
       <div data-testid="organization-coverage-details">

diff --git a/ui/src/Organization/Coverage/__tests__/OrganizationCoverageDetails.spec.tsx b/ui/src/Organization/Coverage/__tests__/OrganizationCoverageDetails.spec.tsx
@@ -0,0 +1,66 @@
+import "@testing-library/jest-dom/extend-expect";
+import React from "react";
+import { render } from "@testing-library/react";
+import OrganizationCoverageDetails from "../OrganizationCoverageDetails";
+import {
+  OrganizationCoverage,
+  RepositoryCoverage,
+} from "../../../model/OrganizationModel";
+import {
+  Coverage,
+  CoverageStat,
+  CoverageStats,
+} from "../../../model/TestRunModel";
+
+describe("OrganizationCoverageDetails", () => {
+  it("should render coverage details even when one project doesn't have any coverage stats", async () => {
+    const orgName = "my-org";
+    const organizationCoverage = {
+      repositories: [
+        {
+          publicId: "no-coverage-id",
+          repoName: "no-coverage-repo",
+          coverage: null,
+        } as RepositoryCoverage,
+        {
+          publicId: "has-coverage-id",
+          repoName: "has-coverage-repo",
+          coverage: {
+            groups: [],
+            overallStats: {
+              branchStat: {
+                covered: 80,
+                missed: 20,
+                total: 100,
+                coveredPercentage: 80,
+              } as CoverageStat,
+              lineStat: {
+                covered: 80,
+                missed: 20,
+                total: 100,
+                coveredPercentage: 80,
+              } as CoverageStat,
+              statementStat: {
+                covered: 80,
+                missed: 20,
+                total: 100,
+                coveredPercentage: 80,
+              } as CoverageStat,
+            } as CoverageStats,
+          } as Coverage,
+        } as RepositoryCoverage,
+      ],
+    } as OrganizationCoverage;
+
+    const { findByTestId } = render(
+      <OrganizationCoverageDetails
+        orgName={orgName}
+        organizationCoverage={organizationCoverage}
+      />
+    );
+
+    expect(await findByTestId("coverage-name-1")).toHaveTextContent(
+      `has-coverage-repo`
+    );
+  });
+});