Merge pull request #129 from craigatk/test-delete

(chore) Adding test case for trying to add an attachment when it is disabled
craigatk · Sep 1, 2020 · 6507e49 · 6507e49
2 parents d594e7e + 26d62fc
commit 6507e49
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/server/server-app/src/test/kotlin/projektor/ApplicationTestCase.kt b/server/server-app/src/test/kotlin/projektor/ApplicationTestCase.kt
@@ -62,7 +62,7 @@ open class ApplicationTestCase {
 
     protected var publishToken: String? = null
 
-    protected var attachmentsEnabled: Boolean? = null
+    protected var attachmentsEnabled: Boolean = false
     protected var attachmentsMaxSizeMB: BigDecimal? = null
     protected var attachmentsAccessKey = "minio_access_key"
     protected var attachmentsBucketName = "attachmentstesting"
@@ -89,7 +89,7 @@ open class ApplicationTestCase {
 
             publishToken?.let { put("ktor.auth.publishToken", it) }
 
-            attachmentsEnabled?.let {
+            if (attachmentsEnabled) {
                 put("ktor.attachment.url", "http://localhost:9000")
                 put("ktor.attachment.bucketName", attachmentsBucketName)
                 put("ktor.attachment.autoCreateBucket", attachmentsAutoCreateBucket.toString())

diff --git a/server/server-app/src/test/kotlin/projektor/attachment/AddAttachmentApplicationTest.kt b/server/server-app/src/test/kotlin/projektor/attachment/AddAttachmentApplicationTest.kt
@@ -101,4 +101,23 @@ class AddAttachmentApplicationTest : ApplicationTestCase() {
             }
         }
     }
+
+    @Test
+    fun `when attachments not enabled should return 400 when trying to add attachment`() {
+        val publicId = randomPublicId()
+        attachmentsEnabled = false
+
+        val attachmentBytes = File("src/test/resources/test-attachment.txt").readBytes()
+
+        withTestApplication(::createTestApplication) {
+            handleRequest(HttpMethod.Post, "/run/$publicId/attachments/test-attachment.txt") {
+                testRunDBGenerator.createSimpleTestRun(publicId)
+
+                addHeader("content-length", attachmentBytes.size.toString())
+                setBody(attachmentBytes)
+            }.apply {
+                expectThat(response.status()).isEqualTo(HttpStatusCode.BadRequest)
+            }
+        }
+    }
 }