Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes identity number field on onboarding flow #81

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Removes identity number field on onboarding flow #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7733f9
Add card clone adapter (#80)
abalikci Mar 28, 2024
e4975ec
Removes identity number field on onboarding flow
semihshn Mar 29, 2024
e462cbc
Update
semihshn Mar 29, 2024
d6ab973
Merge branch 'master' into remove-identity-number
semihshn Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions adapter/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,7 +1378,6 @@ type CreateMemberRequest struct {
Address string `json:"address,omitempty"`
Email string `json:"email,omitempty"`
PhoneNumber string `json:"phoneNumber,omitempty"`
IdentityNumber string `json:"identityNumber,omitempty"`
ContactName string `json:"contactName,omitempty"`
ContactSurname string `json:"contactSurname,omitempty"`
MemberType MemberType `json:"memberType,omitempty"`
Expand All @@ -1397,7 +1396,6 @@ type UpdateMemberRequest struct {
Address string `json:"address,omitempty"`
Email string `json:"email,omitempty"`
PhoneNumber string `json:"phoneNumber,omitempty"`
IdentityNumber string `json:"identityNumber,omitempty"`
ContactName string `json:"contactName,omitempty"`
ContactSurname string `json:"contactSurname,omitempty"`
MemberType MemberType `json:"memberType,omitempty"`
Expand Down Expand Up @@ -1435,7 +1433,6 @@ type MemberResponse struct {
Email *string `json:"email"`
Address *string `json:"address"`
PhoneNumber *string `json:"phoneNumber"`
IdentityNumber *string `json:"identityNumber"`
ContactName *string `json:"contactName"`
ContactSurname *string `json:"contactSurname"`
LegalCompanyTitle *string `json:"legalCompanyTitle"`
Expand Down
9 changes: 3 additions & 6 deletions tests/onboarding_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package tests
import (
"context"
"fmt"
"testing"
"time"

"github.com/craftgate/craftgate-go-client/adapter"
craftgate "github.com/craftgate/craftgate-go-client/adapter"
"github.com/davecgh/go-spew/spew"
"testing"
"time"
)

var onboardingClient, _ = craftgate.New("api-key", "secret-key", "https://sandbox-api.craftgate.io")
Expand Down Expand Up @@ -41,7 +42,6 @@ func Test_CreateSubMerchantMember(t *testing.T) {
Email: "[email protected]",
PhoneNumber: "905551111111",
Iban: "TR930006701000000001111111",
IdentityNumber: "11111111110",
LegalCompanyTitle: "Dem Zeytinyağı Üretim Ltd. Şti.",
Name: "Dem Zeytinyağı Üretim Ltd. Şti.",
MemberType: craftgate.MemberType_LIMITED_OR_JOINT_STOCK_COMPANY,
Expand All @@ -68,7 +68,6 @@ func Test_CreateBuyerAndSubMerchantMember(t *testing.T) {
Email: "[email protected]",
PhoneNumber: "905551111111",
Iban: "TR930006701000000001111111",
IdentityNumber: "11111111110",
LegalCompanyTitle: "Dem Zeytinyağı Üretim Ltd. Şti.",
Name: "Dem Zeytinyağı Üretim Ltd. Şti.",
MemberType: craftgate.MemberType_LIMITED_OR_JOINT_STOCK_COMPANY,
Expand All @@ -94,7 +93,6 @@ func Test_UpdateSubMerchantMember(t *testing.T) {
Email: "[email protected]",
PhoneNumber: "905551111111",
Iban: "TR930006701000000001111111",
IdentityNumber: "11111111110",
LegalCompanyTitle: "Dem Zeytinyağı Üretim Ltd. Şti.",
Name: "Dem Zeytinyağı Üretim Ltd. Şti.",
MemberType: craftgate.MemberType_LIMITED_OR_JOINT_STOCK_COMPANY,
Expand All @@ -121,7 +119,6 @@ func Test_UpdateBuyerMember(t *testing.T) {
Email: "[email protected]",
PhoneNumber: "905551111111",
Iban: "TR930006701000000001111111",
IdentityNumber: "11111111110",
LegalCompanyTitle: "Dem Zeytinyağı Üretim Ltd. Şti.",
Name: "Dem Zeytinyağı Üretim Ltd. Şti.",
MemberType: craftgate.MemberType_PERSONAL,
Expand Down
Loading