Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feeds are now processed as batched jobs.
Notes:
services/Process.php->processFeed()
- the last parameter ($feedData
) is no longer optionalservices/Process.php->afterProcessFeed()
- now accepts the 4th param ($startTime
); it’s needed for the time calculations to work correctly for the paginated view; if omitted, the time calculation will still work, but as before - timing only the last pageservices/Process.php->beforeProcessFeed()
is now split into 2 methods,beforeProcessFeed()
, which runs before each page (if the feed is not paginated, then there’s only one page), andgetFeedSettings()
, which runs before each batchProcessing X elements finished in <number>s
=> it looks like this was a bit buggy before for paginated feeds; it reported the total number of processed items but only really measured the time of the past page (fixed now)Finished preparing for feed processing.
because the$stepKey
was not cleared as expected (fixed now)Related issues
#1584