Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't validate settings if in read-only mode #267

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

don't validate settings if in read-only mode #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ protected function settingsHtml(): ?string
{
// Get and pre-validate the settings
$settings = $this->getSettings();
$settings->validate();

$readOnly = !Craft::$app->getConfig()->getGeneral()->allowAdminChanges;
if (!$readOnly) {
$settings->validate();
}

// Get the settings that are being defined by the config file
$overrides = Craft::$app->getConfig()->getConfigFromFile(strtolower($this->handle));
Expand Down
Loading