Fix max elements for variants

craftcms · Jan 13, 2025 · 379c997 · 379c997
1 parent 7df7977
commit 379c997
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed a bug where product type’s “Max Variants” setting was not being respected. ([#3845](https://github.com/craftcms/commerce/issues/3845))
 - Fixed a bug where products could be duplicated without the “Create products” permissions. ([#3838](https://github.com/craftcms/commerce/issues/3838))
 
 ## 5.2.11 - 2025-01-02

diff --git a/src/fieldlayoutelements/VariantsField.php b/src/fieldlayoutelements/VariantsField.php
@@ -59,8 +59,12 @@ protected function inputHtml(ElementInterface $element = null, bool $static = fa
 
         Craft::$app->getView()->registerDeltaName($this->attribute());
 
+        $maxVariants = $element->getType()->maxVariants;
+
         return $element->getVariantManager()->getIndexHtml($element, [
             'canCreate' => !$static,
+            'minElements' => 0,
+            'maxElements' => $maxVariants ?? null,
             'allowedViewModes' => [ElementIndexViewMode::Cards, ElementIndexViewMode::Table],
             'sortable' => !$static,
             'fieldLayouts' => [$element->getType()->getVariantFieldLayout()],